[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [RFC] 1 of 4 Linux Container support - base



On Wed, Mar 19, 2008 at 11:14:15PM -0700, Dave Leskovec wrote:
> This patch adds the base linux container support.

  Looks fine to me, with the only suggestion below:

> Index: b/src/virterror.c
> ===================================================================
> --- a/src/virterror.c	2008-02-27 02:37:19.000000000 -0800
> +++ b/src/virterror.c	2008-03-14 10:55:36.000000000 -0700
> @@ -296,6 +296,9 @@
>          case VIR_FROM_STATS_LINUX:
>              dom = "Linux Stats ";
>              break;
> +        case VIR_FROM_LXC:
> +            dom = "LXC ";
> +            break;

  Since we are trying to provide the user with strings for the 
domain of the error, use "Linux Container" instead, it will be 
clearer, even if a bit long,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]