[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [RFC] 4 of 4 Linux Container support - start container



On Wed, Mar 19, 2008 at 11:16:32PM -0700, Dave Leskovec wrote:
> This patch adds the start container support.  A couple new source files are
> added - lxc_container.h and lxc_container.c  These contain the setup code that
> runs within the container namespace prior to exec'ing the user specified init.

IMHO there's too much forking going on here. With the stateful driver we 
should have the daemon be the parent of the forked VM as per the QEMU 
driver. This will avoid the need to unsafely re-write the config files. 
It will also enable errors during the domain creation process to be correctly
propagated back to the caller.

eg, when I tested this patch 'mount' failed, but the libvirt driver still
thought all we fine becasue this part of  domain creation was being done
in the double-fork()d child and thus no errors could be propagated back.

Regards,
Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]