[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [RFC] 0 of 4 Linux Container support




Daniel Veillard wrote:
> On Thu, Mar 20, 2008 at 01:25:05PM -0400, Daniel Veillard wrote:
>> On Thu, Mar 20, 2008 at 10:20:22AM -0700, Dave Leskovec wrote:
>>> Daniel Veillard wrote:
>>>>   I would rather keep the type attribute value small, and if possible
>>>> the same as the one used for the connection URIs, 'lxr' would be just fine
>>>> IMHO
>>> I'll second Vivek's suggestion for 'lxc' for consistency.
>>   Of course !
>>
>>>>   What do you think of the idea of commiting parts 1/2/3 once we are done
>>>> with their second review ?
>>> I think that'd be great.
>>   okay, let's try to do this over the next few days, I think I commented
>> on the 3 modules, it can mostly go as is, I would just revamp the configuration
>> parsing as indicated earlier.
> 
>   Okay, I did just that, I applied th 3 first patches to CVS and commited
> after changing the type to 'lxc' and growing the XML buffer size to 16K
> Let's use patches based on CVS from now on :-)
> 
>   I will look now at cleaning up the parsing code as explained in my review,
> that I can do easilly,
> 
> Daniel
> 

Excellent.  Thanks!

-- 
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]