[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] reindent __virErrorMsg with spaces instead of tabs



On Sun, Mar 23, 2008 at 07:48:58PM +0100, Guido Günther wrote:
> __virErrorMsg is a mix of tabs and spaces which makes it a bit
> hard to read. This patch cleans this up. Please apply.

  Hum, could you send those kind of patches as attachments in the future ?
Basically assuming spaces/tabs are correctly preserved in an email body is
taking unecessary risks. Also having a name for the patch and being able
to download them from on-line email archives is a good thing,

  Now for the content of the patch, it seems to remove all tabs and replace
them with 8 spaces. Is that really a better way, why use 8 characters when
you can use one for the same purpose ? One could argue either way, maybe
we should standardize on tabs, maybe we should replace them all, but I'm
not sure the second one is really the right way. At the moment nearly all
C files uses tabs, and i know I'm using them to align parameters lists
in headers too, so starting a tab replacement would hit nearly all the code.

  Also make sure you editor use tab to align to the next 8 character boundary.
To me that renders correctly in vim (I have tabstop=8).

  thanks,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]