[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] reindent __virErrorMsg with spaces instead of tabs



On Tue, Mar 25, 2008 at 11:06:02AM +0100, Guido Günther wrote:
> HI Daniel,

  Hi,

[...]
> >   Now for the content of the patch, it seems to remove all tabs and replace
> > them with 8 spaces. Is that really a better way, why use 8 characters when
> > you can use one for the same purpose ? One could argue either way, maybe
> No, it uses 4 spaces for each indentation level, this is what the other
> files I checked (mostly qemu_*.c, xml.c) use and remote_internal.c even
> has:

  you just then use one tab for 2 indentation level, works just fine when I
use vim on that file, really...

> /*
>  * vim: set tabstop=4:
>  * vim: set shiftwidth=4:
>  * vim: set expandtab:
>  */
> which is basically what I used for reindenting virterror.c. So the patch
> is just to make things consistent with the rest of the c code.

  To me the patch I got replaced all tabs instead of using tabs for
indenting of 2 levels. I also have
   tabstop=8
in my vim setup, that's rather classic.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]