[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] deep copy dom structure



On Mon, Mar 31, 2008 at 02:35:31PM +0100, Daniel P. Berrange wrote:
> On Mon, Mar 31, 2008 at 08:49:12AM -0400, Daniel Veillard wrote:
> > On Mon, Mar 31, 2008 at 08:12:19AM -0400, Daniel Veillard wrote:
> > > On Mon, Mar 31, 2008 at 01:02:49PM +0100, Daniel P. Berrange wrote:
> > > > We should at the very least NULL-ify the dom/net fields in the Error 
> > > > object associated with the Connection when we free the Domain/Network
> > > > object.
> > > 
> > >   agreed, very simple test but avoids dandling pointers.
> > 
> >   My patch for this. it's a bit more complex because we also keep a 
> > global variable for the last variable, and that needed to be exported to
> > the hash module, it's still rather simple,
> 
> Yes, that's pretty much what I was thinking we should do - ACK from me.

  thanks,

  commited to CVS,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]