[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Re: Lxc conf patch



Meant to include this in the last reply - Here's a patch for the lxcFreeVMs() issue:

> 
> This breaks doesn't it?  After calling lxcFreeVM(), curVm is no longer valid
> since it was free()'d.  Need to pull out the next pointer before lxcFreeVM().
> 


-- 
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
 src/lxc_conf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/src/lxc_conf.c
===================================================================
--- a/src/lxc_conf.c	2008-03-31 05:02:12.000000000 -0700
+++ b/src/lxc_conf.c	2008-03-31 15:13:36.000000000 -0700
@@ -810,8 +810,8 @@
     lxc_vm_t *nextVm;
 
     while (curVm) {
-        lxcFreeVM(curVm);
         nextVm = curVm->next;
+        lxcFreeVM(curVm);
         curVm = nextVm;
     }
 }

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]