[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] sytnax-check: add a check for risky ctype macro use



On Thu, May 08, 2008 at 04:41:21PM +0200, Jim Meyering wrote:
> A follow-up to the patch that introduced to_uchar.
> This rule will ensure no new offenders sneak back in.

  Fine by me, even if my own feeling would be to rather check we don't
use is* and to* at all since their behaviour is locale dependant and
being macros they don't do type checking. But I'm certainly biased on
this topic by my XML background :-)

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]