[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] avoid using STREQLEN with a literal; use STRPREFIX instead



On Thu, May 15, 2008 at 04:13:14PM +0200, Jim Meyering wrote:
> The goal of this change is to remove the error-prone duplication
> between literal strings and corresponding literal length.
> 
> This was almost 100% mechanical:
> 
> I manually reversed the two args with the "vnet" use in qemu_conf.c,
> so that the perl code would transform that one, too.

Yes, this looks good to me. I've scanned the changes and all appear correct.

Dan
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]