[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] avoid using STREQLEN with a literal; use STRPREFIX instead



"Daniel P. Berrange" <berrange redhat com> wrote:
> On Thu, May 15, 2008 at 04:13:14PM +0200, Jim Meyering wrote:
>> The goal of this change is to remove the error-prone duplication
>> between literal strings and corresponding literal length.
>>
>> This was almost 100% mechanical:
>>
>> I manually reversed the two args with the "vnet" use in qemu_conf.c,
>> so that the perl code would transform that one, too.
>
> Yes, this looks good to me. I've scanned the changes and all appear correct.

Thanks for the quick review.  Committed.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]