[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Pass -name argument to QEMU



On Thu, May 15, 2008 at 11:20:50PM +0200, Soren Hansen wrote:
> On Tue, May 13, 2008 at 12:21:02AM +0100, Daniel P. Berrange wrote:
> > -        if (strstr(help, "\n-drive"))
> > -            *flags |= QEMUD_CMD_FLAG_DRIVE_OPT;
> [...]
> > +        if (strstr(help, "-drive"))
> > +            *flags |= QEMUD_CMD_FLAG_DRIVE;
> 
> Why this change? I put the \n in front to prevent something like
> "disk-drive" in a descriptive text making libvirt think that "-drive"
> was a valid option.

Xenner doesn't start its help output right at the start of line, and
there isn't any other output there that causes ambiguity in current
qemu help output:

  # qemu-kvm | grep -- -drive
  -drive [file=file][,if=type][,bus=n][,unit=m][,media=d][index=i]

If one happens to be added in the future, that's fine because -drive will
be enabled anyway for future releases.

Regards,
Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]