[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error



On Tue, May 20, 2008 at 02:39:52PM +0100, Daniel P. Berrange wrote:
> I'm not entirely convinced yet - the code certainly suggests to me that
> we need to free these. Only a couple of lines further up we obtain a referenced
> object
> 
>     /* Get the domain and network, if set. */
>     dom = err->dom ? get_nonnull_domain (conn, *err->dom) : NULL;
>     net = err->net ? get_nonnull_network (conn, *err->net) : NULL;
> 
> And __virRaiseError() does *not* own the reference after being called, thus
> we need to explicitly release the reference ourselves.

Agreed with Dan ... I'm not sure how the leaks can go away with the
other patch.  OTOH the ref-counting stuff is complicated.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]