[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Don't rely on host binaries in QEMU tests



On Fri, May 16, 2008 at 04:19:16PM +0100, Daniel P. Berrange wrote:
> The QEMU test suites rely on the QEMU/KVM/Xenner binaries being present
> in /usr/bin. This has obvious problems and is unneccessary. The solution
> is to not use the qemudCapsInit() function which initializes capabilities
> based on binaries present. Instead I add a custom impl just for the test
> cases which adds a pre-defined stable set of capabilities. I also had to
> move a stat() check out of qemudBuildCommandLine() and into its caller.
> It probably should have been there in the first place anyway

  Yup makes sense, +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]