[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Add NUMA apis to remote driver



"Richard W.M. Jones" <rjones redhat com> wrote:
> On Tue, May 20, 2008 at 03:51:53PM +0100, Daniel P. Berrange wrote:
>> +if GLIBC_RPCGEN
>> +	mv $@ $  bak
>> +	sed -e 's/\t/        /g' $  bak > $@
>> +endif
>
> I guess it doesn't matter in a generated file, but is the above
> correct?  Probably better to use the 'expand' command, if it is
> available.

Thanks for bringing that up.
While I don't know how portable expand is,
(I've never used it in a portable build script or Makefile)
it's certain to be less portable than sed.

However, (to my constant chagrin) \t is not portable in sed regexps.
Makes me want to use perl -pe 's/...//' FILE instead.
With Perl, "\t" *does* work portably.
On the other hand, maybe using perl (or expand) would be ok here,
since the only time an end user runs those rules is if/when they
modify a dependent .x file.

Otherwise just use a literal TAB character.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]