[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Fix some more memory leaks



On Thu, May 22, 2008 at 11:13:31AM +0200, Jim Meyering wrote:
> > -    if (r == -1) return -1;
> > +    if (r == -1) {
> > +        virDomainFree (dom);
> > +        return -1;
> > +    }
> > +    virDomainFree (dom);
> 
> Here, you can call virDomainFree just once, before the "if", regardless.

I've changed this one, since it was already using a return status variable,
but left the other as is.

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]