[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Add NUMA info to QEMU driver



On Tue, May 20, 2008 at 05:01:31PM +0100, Daniel P. Berrange wrote:
> On Tue, May 20, 2008 at 02:15:59PM +0200, Jim Meyering wrote:
> > "Daniel P. Berrange" <berrange redhat com> wrote:
> > > This patch includes NUMA topology info in the QEMU driver capabilities
> > > XML output. It also implements the free memory driver APIs. This is done
> > > with the LGPL'd  numactl library. The configure script probes for it and
> > > only enables this functionality if it is found. The numactl library has
> > > been around for quite a while - RHEL-3 vintage at least
> > 
> > Looks fine, modulo a few nits...
> > 
> > ...
> > > +        for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++)
> > > +            if ((mask[(i / MAX_CPUS_MASK_SIZE)] >> (i % MAX_CPUS_MASK_SIZE)) & 1)
> > ...
> > > +        for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++)
> > > +            if ((mask[(i / MAX_CPUS_MASK_SIZE)] >> (i % MAX_CPUS_MASK_SIZE)) & 1)
> > 
> > The above bit-is-set query deserves a macro.
> 
> Here's a update with that macro-ized, and the stupid fprintf()'s that rich
> noticed removed.

I've comitted this patch now.

Regards,
Daniel
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]