[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Clean up QEMU driver argv builder



"Daniel P. Berrange" <berrange redhat com> wrote:
> Daniel pointed out that the way we build up the QEMU argv strnig is becoming
> rather unscalable / error prone. This patch refactors it into to use a short
> macro to do memory allocation/reallocation, which clears it up quite nicely
>
>  qemu_conf.c |  293 +++++++++++++++++++++++-------------------------------------
>  1 file changed, 116 insertions(+), 177 deletions(-)

Very nice.
I see you also plugged a soundhw/modstr leak.

ACK.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]