[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Clean up QEMU driver argv builder



On Thu, May 22, 2008 at 07:00:50PM -0400, Daniel Veillard wrote:
> On Thu, May 22, 2008 at 05:34:19PM +0100, Daniel P. Berrange wrote:
> > Daniel pointed out that the way we build up the QEMU argv strnig is becoming
> > rather unscalable / error prone. This patch refactors it into to use a short
> > macro to do memory allocation/reallocation, which clears it up quite nicely
> 
>   Yup, thanks a lot, easier to read and check ! +1
> 
> I always feel a bit surprized by macro defined within functions, but
> I don't have a good rationale for not doing this :-) (maybe not suggest
> the scope might be limited to the function)

Thanks, I've committed this now.

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]