[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Misc fixes to qparams



On Thu, May 22, 2008 at 05:51:56PM +0100, Richard W.M. Jones wrote:
> On Thu, May 22, 2008 at 12:49:04AM +0100, Daniel P. Berrange wrote:
> >  - In the qparam_query_parse() method, after appending each (name,value)
> >    pair of params, it failed to free the temporary buffers for the 
> >    (name,value) pair.
> >  - Did not allow for ';' as a valid query parameter separator
> >  - In a couple of OOM cleanup scenarios it failed to free buffers allocated
> >    earlier on
> 
> Yes this code looks fine to me.

Thanks, I've comitted this patch

Daniel
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]