[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH]show the autostart status when displaya'virsh dominfo'.

On Wed, May 28, 2008 at 11:21:05AM +0900, Atsushi SAKAI wrote:
> Hi, Rich and Dan 
> Thank you for fixing this.
> I think it should be noted about submitting patch on HACKING file or others.
> How do you think?
> (like make check; make syntax-check; make tests)

Yes, basically the three things you should run before committing patches

    make check
    make syntax-check
    make valgrind        (in the tests/ sub-dir)

The latter checks for memory leaks.

Of course I myself forget this often - which is why we have the automated
nightly builds, so we never miss the problem for longer than a day

|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]