[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] lxc: store tty pid



Daniel Veillard wrote:
> On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote:
...
> 
>   Hum, I'm surprized the PID file is removed only in lxcDomainUndefine.
> The PID file need to be re-created each time the domain is started. But
> a domain could be started and stopped many time while being defined,
> what happen in a (define/start/stop/start) sequence ? Looks to me the
> O_CREAT flag in the second start would break because the PID file is still
> here ...
> 
>   Maybe I'm just wrong but if you could just double check that scenario before
> the commit, that would be nice :-)
> 
> Daniel
> 

O_CREAT just causes the file to be created if it doesn't exist.  O_EXCL will
trigger an error if the file already exists.

I'd considered removing it after killing the tty process but don't recall now
why I didn't do that.  I think it makes sense to do that so I'll make the change
with the ones from Jim and Dan.

Thanks!

-- 
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]