[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Support events for define/undefine in QEMU



On Fri, Nov 14, 2008 at 05:51:22PM +0000, Daniel P. Berrange wrote:
> This patch adds support for the DEFINED and UNDEFINED events in the
> QEMU drive. This was more involved than I expected, because when the
> daemon gets SIGHUP it re-loads config files and we need to broadcast
> events for each new config file it finds. So I had to add a callback
> to the internal virDomainLoadAllConfigs method.

  okay,

> The LoadConfig method also had a bogus line of code resetting the
> domain state to SHUTOFF, which made all your active VMs suddenlly
> appear inactive, after the daemon got SIGHUP !

 whoops :-)


  Looks fine, +1

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]