[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 7/12: Public API for node devices



On Fri, Nov 14, 2008 at 01:57:26PM -0500, David Lively wrote:
> On Fri, 2008-11-14 at 13:28 +0000, Daniel P. Berrange wrote:
> > On Fri, Nov 14, 2008 at 12:46:09PM +0000, Mark McLoughlin wrote:
> > > 
> > > On Thu, 2008-11-13 at 17:30 +0000, Daniel P. Berrange wrote:
> > > > This patch is the public API parts of the node device enumeration code.
> > > > No changes since David's last submission of this, except for some
> > > > Makefile tweaks
> > > > 
> > > > +
> > > > +int                     virNodeNumOfDevices     (virConnectPtr conn,
> > > > +                                                 unsigned int flags);
> > > > +
> > > > +int                     virNodeListDevices      (virConnectPtr conn,
> > > > +                                                 char **const names,
> > > > +                                                 int maxnames,
> > > > +                                                 unsigned int flags);
> > > > +
> > > > +int                     virNodeNumOfDevicesByCap (virConnectPtr conn,
> > > > +                                                  const char *cap,
> > > > +                                                  unsigned int flags);
> > > > +
> > > > +int                     virNodeListDevicesByCap (virConnectPtr conn,
> > > > +                                                 const char *cap,
> > > > +                                                 char **const names,
> > > > +                                                 int maxnames,
> > > > +                                                 unsigned int flags);
> > > 
> > > How about combining these two sets of functions and if the capability
> > > type isn't supplied list all devices?
> > 
> > Yes, we could just remove the ByCap  APIs, and add the 'const char *cap'
> > arg to the first two APIs, allowing NULL.
> 
> I like this idea as well.

  Okay, then let's do this !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]