[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Support events for define/undefine in QEMU



On Mon, Nov 17, 2008 at 01:05:42PM +0100, Daniel Veillard wrote:
> On Fri, Nov 14, 2008 at 05:51:22PM +0000, Daniel P. Berrange wrote:
> > This patch adds support for the DEFINED and UNDEFINED events in the
> > QEMU drive. This was more involved than I expected, because when the
> > daemon gets SIGHUP it re-loads config files and we need to broadcast
> > events for each new config file it finds. So I had to add a callback
> > to the internal virDomainLoadAllConfigs method.
> 
>   okay,
> 
> > The LoadConfig method also had a bogus line of code resetting the
> > domain state to SHUTOFF, which made all your active VMs suddenlly
> > appear inactive, after the daemon got SIGHUP !
> 
>  whoops :-)
> 
> 
>   Looks fine, +1

I've comitted this patch too

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]