[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Java bindings for domain events



On Tue, Nov 18, 2008 at 11:06:10AM -0500, David Lively wrote:
> The attached patch (against libvirt-java) implements Java bindings for
> libvirt domain events.  This version provides a libvirt EventImpl
> running in its own Java Thread, and provides per-Connect synchronization
> that makes using the bindings thread-safe.  (Note the Domain, Network,
> StoragePool, and StorageVol methods also synchronize on their Connect
> object, as required by libvirt.  I have similar changes for
> NodeDevice.java that need to be made when that code is checked in.)
> 
> This version of the patch also implements and uses an enum class
> (DomainEvent.Type), as suggested by Tóth István.
> 
> IMPORTANT: THIS PATCH WILL BREAK THINGS UNLESS THE NEXT [PATCH 2/2] IS
> APPLIED TO libvirt FIRST.  Also, libvirt must be compiled WITH_PTHREADS
> for Java events to work.

  my main concern is to keep Java bindings working on Windows. Does our
Win32 build includes pthreads ? I would love to get some positive
feedback on that point (or even better that the java bindings do indeed
work on Win32 with that patch).

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]