[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Change signature of virEventAddHandle to allow multiple calls per FD



On Wed, Nov 19, 2008 at 02:23:03PM +0100, Daniel Veillard wrote:
> On Mon, Nov 17, 2008 at 04:58:51PM +0000, Daniel P. Berrange wrote:
> > As discussed previously, this patch changes the semantics of the public
> > API for dealing with file handle watches. Previously we would track the
> > watch based on  the file handle number directly. With this change, the
> > virEventAddHandle method returns an integer 'watch' number. This watch
> > number is required when unregistering or updating a watch. The watch is
> > also passed into the callback when an event occurrs. This allows for
> > multiple watches to be registered against the same file descriptor.
> > 
> > There was quite alot of fallout from this patch requiring many callers
> > to be updated to comply with the new semantics.
> 
>   Okay, +1

Thanks, this is committed too now.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]