[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: virsh-all: new script



On Fri, Nov 21, 2008 at 11:16:18AM +0100, Jim Meyering wrote:
> Actually, this was the first step.
> This tiny script merely invokes all commands blindly,
> solely to get test coverage, even if they (as most do) fail.

It at least verifies that the commands don't crash or leak
memory in the error paths :-)

> +
> +if test "$VERBOSE" = yes; then
> +  set -x
> +  virsh --version
> +fi
> +
> +. $srcdir/test-lib.sh

$srcdir won't be set if you just invoke the test case directly 
as ./virsh-all. Can you add a default value assuming non-VPATH
build, eg

   test -z "$srcdir" && srcdir=`pwd`

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]