[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Xen Events Updated



On Tue, Nov 25, 2008 at 11:19:04AM +0100, Daniel Veillard wrote:
> On Mon, Nov 24, 2008 at 03:44:28PM +0000, Daniel P. Berrange wrote:
> > +++ b/configure.in	Mon Nov 24 09:08:01 2008 -0500
> > @@ -147,6 +147,8 @@ dnl Allow to build without Xen, QEMU/KVM
> >  dnl Allow to build without Xen, QEMU/KVM, test or remote driver
> >  AC_ARG_WITH([xen],
> >  [  --with-xen              add XEN support (on)],[],[with_xen=yes])
> > +AC_ARG_WITH([xen-inotify],
> > +[  --with-xen-inotify      add XEN inotify support (on)],[],[with_xen_inotify=yes])
> >  AC_ARG_WITH([qemu],
> >  [  --with-qemu             add QEMU/KVM support (on)],[],[with_qemu=yes])
> >  AC_ARG_WITH([uml],
> > @@ -333,6 +335,17 @@ AM_CONDITIONAL([WITH_XEN], [test "$with_
> >  AM_CONDITIONAL([WITH_XEN], [test "$with_xen" = "yes"])
> >  AC_SUBST([XEN_CFLAGS])
> >  AC_SUBST([XEN_LIBS])
> > +
> > +dnl
> > +dnl check for kernel headers required by xen_inotify
> > +dnl
> > +if test "$with_xen_inotify" != "no"; then
> > +    AC_CHECK_HEADER([linux/inotify.h],[],[with_xen_inotify=no])
> > +fi
> > +if test "$with_xen_inotify" = "yes"; then
> > +    AC_DEFINE_UNQUOTED([WITH_XEN_INOTIFY], 1,[whether Xen inotify sub-driver is enabled])
> > +fi
> > +AM_CONDITIONAL([WITH_XEN_INOTIFY], [test "$with_xen_inotify" = "yes"])
> 
>   I would suggest we also test there that xen is enable before adding
> xen_inotify support. I don't think it makes sense to activate the later
> if the former is not selected or detected.

Good idea, I'm committing with this addition:

 dnl
 dnl check for kernel headers required by xen_inotify
 dnl
+if test "$with_xen" != "yes"; then
+    with_xen_inotify=no
+fi
 if test "$with_xen_inotify" != "no"; then
     AC_CHECK_HEADER([linux/inotify.h],[],[with_xen_inotify=no])
 fi


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]