[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix build for srcdir != builddir



On Mon, Nov 24, 2008 at 02:52:50PM +0100, Guido G?nther wrote:
> Hi,
> libvirt_sym.version is looked for at the wrong location. O.k. to apply?

I discovered one tiny snag with this change

>  		    @CYGWIN_EXTRA_LIBADD@ ../gnulib/lib/libgnu.la
> -libvirt_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libvirt_sym.version \
> +libvirt_la_LDFLAGS = -Wl,--version-script=$(builddir)/libvirt_sym.version \
>                       -version-info @LIBVIRT_VERSION_INFO@ \
>                      $(COVERAGE_CFLAGS:-f%=-Wc,-f%) \
>                      $(LIBXML_LIBS) $(SELINUX_LIBS) \
>  		    $(XEN_LIBS) $(DRIVER_MODULE_LIBS) \
>  		    @CYGWIN_EXTRA_LDFLAGS@ @MINGW_EXTRA_LDFLAGS@
>  libvirt_la_CFLAGS = $(COVERAGE_CFLAGS) -DIN_LIBVIRT
> -libvirt_la_DEPENDENCIES = $(libvirt_la_LIBADD) $(srcdir)/libvirt_sym.version
> +libvirt_la_DEPENDENCIES = $(libvirt_la_LIBADD) $(builddir)/libvirt_sym.version

$(builddir) does not exist on RHEL-5's version of automake. Since the
build dir is always just '.', it left it undefined. So I've simply
removed the $(builddir) usage completely, letting it assume current
directory.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]