[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] doc nits



Daniel Veillard <veillard redhat com> wrote:
> On Tue, Nov 25, 2008 at 01:35:26PM +0100, Jim Meyering wrote:
>> I noticed the following go by yesterday,
>> but won't have time to address them:
>> 
>>   Function comment for virConnectDomainEventRegister lacks description of arg freecb
>>   Function comment for virNodeDeviceGetName lacks description of the function
>>   Function comment for virNodeDeviceGetParent lacks description of the function
>>   Function comment for virNodeDeviceNumOfCaps lacks description of the function
>>   Function comment for virNodeDeviceNumOfCaps lacks description of the function
>>   Missing * in function comment for virDomainMigrateFinish
>>   Missing * in function comment for virDomainMigrateFinish2
>>   Missing * in function comment for virDomainMigratePerform
>>   Missing * in function comment for virDomainMigratePrepare
>>   Missing * in function comment for virDomainMigratePrepare2
>>   Missing * in function comment for virDrvSupportsFeature
>
>   Following patch should take care of those. For the last set they are
> internal and the simplest was to extend apibuild.py with an
> ignore_functions list

Looks fine, and does avoid all of those diagnostics.
ACK.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]