[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2]: Give /dev/disk/by-{id, path} a chance to exist



On Wed, Nov 26, 2008 at 05:08:47PM +0100, Chris Lalancette wrote:
> This patch is the same idea as my previous patch for giving
> /dev/disk/by-{id,path} a chance to exist.  Currently libvirt can race with udev
> creation of /dev/disk/by-{id,path}, so if we fail to open the directory, retry
> up to 5 seconds.  This is only likely to happen on hosts that are:
> 
> 1) diskless (so /dev/disk/by-{id,path} doesn't exist already), and
> 2) slow, and/or heavily loaded (meaning that udev can take some time to create
> the /dev nodes).
> 
> Based on the feedback from Dan and Jim, I updated the patch to look more like
> what is elsewhere in libvirt.

ACK to this.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]