[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2]: Call udevsettle in the appropriate places



On Thu, Nov 27, 2008 at 08:53:49AM +0100, Chris Lalancette wrote:
> > This will set UDEVSETTLE=udevsettle even if it doesn't exist. This will
> > result in us running it on every OS we build on. We should not set this
> > variable if its not found.
> 
> Right, both points make sense.  I think the following patch should address it; I
> only conditionally set the UDEVADM variable if I find it.  So, for machines
> without it, the meat of virStorageBackendWaitForDevices is compiled out.  In
> places where I've found it on the build machine, I then do "access" for
> executable at runtime, and only if that succeeds do I run it.  Does that seem
> correct?  In addition, based on the comment from Guido, I changed it over to use
> "udevadm settle" instead of "udevsettle".

  This patch looks fine to me, +1

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]