[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Fix QEMU/UML use of libnuma



On Fri, Nov 28, 2008 at 08:56:57AM +0100, Chris Lalancette wrote:
> Daniel P. Berrange wrote:
> > The 2.x series of numactl releases changed the ABI/API for certain
> > libnuma.so functions we use. Fortunately it turns out that they provide
> > back-compatability of both ABI and API with a combo of linker script
> > magic, and header file inline compat functions. So, all we need todo
> > is #define NUMA_VERSION1_COMPATIBILITY before include numa.h in our
> > code.
> > 
> > This new code did, however, expose a bug in our use of the existing
> > API. We were calculating size in bytes, instead of size in longs, so
> > were passing a buffer that was 8 times to large. Harmless, but the
> > new libnuma validates that the buffer is expected size. So this patch
> > also fixes us to pass & allocate correct  buffer size. 
> > 
> > Finally, also add a missing BuildRequire on numactl-devel, and fixes
> > the libvirtd automake build dependancy
> 
> Yep, all makes sense, and fixes the build for me with numactl-devel 
> installed.  ACK.

Comitted this numa fix now.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]