[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains



DB> Should use lxcError() here - as things are setup by virExec(),
DB> calls to lxcError() call to virRaiseError() which ultimately calls
DB> fprintf(). By using lxcError() can we more easily change logging
DB> later if needed.

Indeed.

DB> I think we need to virCgroupRemove() in the error path to cleanup
DB> a partially constructed cgroup ?

Yep, I'll fix that too.

Thanks!

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms us ibm com

Attachment: pgpEW2Jo0b5fH.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]