[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1 of 2] Add internal cgroup manipulation functions



On Wed, Oct 01, 2008 at 11:10:33PM +0100, Daniel P. Berrange wrote:
> On Wed, Oct 01, 2008 at 02:11:24PM -0700, Dan Smith wrote:
> > DB> Rather than rely on this virt type string - virt type is not
> > DB> adding enough uniqueness - can still have a (virttype, name) clash
> > DB> between 2 libvirt drivers. Name is unique per host, per driver, so
> > DB> we'd want to have
> > 
> > DB>  $CONTROLLER_MOUNT/libvirt/$DRIVER_NAME/$DOMAIN_NAME
> > 
> > Hmm, I'm not sure I follow.  It seems like the virt type offers more
> > uniqueness than driver name.
> 
> Both, Xen and QEMU drivers support a virt type of 'hvm'. If both
> drivers have a domain called 'foo', then both would end up using 
> a group of
> 
>    $MOUNT/libvirt/hvm/foo

Opps, I was actually mixing up 'virt type' with 'os type' here. The
virt type will /probably/ be unique, but we don't mandate it, so it
is probably safest to use the driver name.

> Instead of  
> 
>    $MOUNT/libvirt/qemu/foo
>    $MOUNT/libvirt/xen/foo
> 
> Both of which are guarenteed unique


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]