[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 1 of 5: Split network driver out from QEMU



On Fri, Oct 03, 2008 at 01:23:42PM +0100, Daniel P. Berrange wrote:
> Due to historical architectural restrictions the virtual network driver
> is actually part of the QEMU driver. The restrictions have long ago
> been removed, so its overdue to move the network driver out of the QEMU
> driver. This patch does this. It is a straight re-factoring with no
> functional change.

I just noticed a bit of renaming in the functions and of course
the initialization changes. The configurability is also a nice bonus.
Looks fine to me, +1

> The only minor pain point is that the network driver stores it config
> files under  /etc/libvirt/qemu/networks, when ideally it would be in
> /etc/libvirt/networks.  This patch leaves the config files where they
> already are, but I'm not too happy about that. I'd like to move them
> to the correct location and just leave a back-compatability symlink
> or something like that.

  can we just consider this a distribution issue, left to the packaging
system to provide the backward compat link ?

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]