[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 4 of 5: Remove virStoragePoolObjPtr linked list



On Mon, Oct 06, 2008 at 04:54:42PM +0200, Daniel Veillard wrote:
> On Fri, Oct 03, 2008 at 01:28:31PM +0100, Daniel P. Berrange wrote:
> > This patch removes the linked list in the virStoragePoolObjPtr and
> > and virStorageVolDefPtr objects, and adds new virStoragePoolObjList
> > and virStorageVolDefList structs to track pools & vols as arrays. The
> > storage driver driver gets updated to account for this API change.
> 
>   Okay, there is also quite a bit of cleanup in that patch too.
> What about the active and inactive pool counts, is that really not
> work to keep counting those ? just wondering ...

We used to have the explicit active vs inactive count in the domain/network
drivers too, but killed them off. It will complicate thread locking, because
active vs inactive is a property of the individual object and not the 
driver as a whole. 

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]