[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3 of 3] Add cpu_shares support to virsh schedinfo



On Tue, Oct 07, 2008 at 08:30:22AM -0700, Dan Smith wrote:
> diff -r ebecbe5caa03 -r b07cd92a30e9 src/virsh.c
> --- a/src/virsh.c	Tue Oct 07 08:21:50 2008 -0700
> +++ b/src/virsh.c	Tue Oct 07 08:21:50 2008 -0700
> @@ -1114,6 +1114,7 @@
>      {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, gettext_noop("domain name, id or uuid")},
>      {"weight", VSH_OT_INT, VSH_OFLAG_NONE, gettext_noop("weight for XEN_CREDIT")},
>      {"cap", VSH_OT_INT, VSH_OFLAG_NONE, gettext_noop("cap for XEN_CREDIT")},
> +    {"cpu_shares", VSH_OT_INT, VSH_OFLAG_NONE, gettext_noop("cpu shares for LXC")},

Not your fault, but this schedinfo command is a really dumb wrt
to option handling. Requiring that we add new options for every
possible schedular param for every possible hypervisor is just
crazy.

Instead  of using a syntax

    schedinfo --weight 10

it should use

    schedinfo --set weight=10

so it automatically has support for every parameter supported
by the hypervisor in question. It can validate that the user
suplied param name is correct by calling 'virDomainGetSchedularParams'
to see what are available.

We need to implement a --set option, and deprecate use of the existing
--weight and --cap options in the help message/man page.


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]