[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] Add NSIS support to nightly builds



On Wed, Oct 08, 2008 at 04:49:20PM +0100, Richard W.M. Jones wrote:
> --- autobuild.sh.orig	2008-10-08 16:41:26.000000000 +0100
> +++ autobuild.sh	2008-10-08 16:41:31.000000000 +0100
> @@ -87,4 +87,20 @@
>         --define "_sourcedir `pwd`" \
>         -ba --clean mingw32-libvirt.spec
>    fi
> +
> +  if [ -x /usr/bin/nsiswrapper ]; then
> +    # XXX nsiswrapper doesn't really like having 'two roots', so
> +    # we hack around it for the moment.
> +    cp -a $AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw .
> +    cp -a /usr/i686-pc-mingw32/sys-root/mingw/bin/* mingw/bin
> +    export PATH=`pwd`/mingw/bin:$PATH
> +    nsiswrapper --run --verbose \
> +      --name "Libvirt" \
> +      --outfile "libvirt-`date +%Y%m%d`.exe" \
> +      `pwd`/mingw/bin/virsh.exe \
> +      `pwd`/mingw/include/libvirt \
> +      `pwd`/mingw/etc/libvirt \
> +      `pwd`/mingw/lib \
> +      `pwd`/mingw/share
> +  fi
>  fi

I think this is better off as a separate module, building an installer
which provides all the virt tools, hooking that module into the build
system and having it depend on all others. Now the python stuff is 
probably a little too hard in the short term, but there's no reason
we can't integrate libvirt, gtk-vnc & virt-viewer since we've basically
got all the deps for those ported - just need to commit the gtk-vnc
bits upstream.

I also think the installer should be driven off the files in the 
mingw32 sysroot - everything going into the sysroot should be stuff
that is wanted for deployment on windows.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]