[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Support SDL configuration for QEMU driver



On Wed, Oct 08, 2008 at 08:08:35PM +0100, Daniel P. Berrange wrote:
> On Thu, Oct 02, 2008 at 07:37:38PM +0200, Jim Meyering wrote:
> > "Daniel P. Berrange" <berrange redhat com> wrote:
> > ...
> > > Now previously since we just use 'execv' the QEMU process would just
> > > inherit all libvirtd's environment variables. When we now use execve()
> > > no variables are inherited - we have to explicitly set all the ones
> > > we need. I'm not sure what we should consider the mimimum required?
> > >
> > > I'm merely setting  'LC_ALL=C' to ensure it runs in C locale. Do we
> > > need to set $PATH for QEMU - maybe ? Anything else which is good
> > > practice to set ?
> > 
> > If QEMU uses PATH, then propagating that is necessary.
> > I guess it's debatable whether to use PATH=$PATH or
> > to use some hard-coded default on the RHS.  But using PATH=$PATH
> > seems friendlier, in case whatever QEMU uses is in some non-default
> > location.
> > 
> > If it uses mkstemp or the like, then including TMPDIR would be good.
> > Depending on QEMU, maybe things like HOME, USER, LOGNAME too.
> 
> Here's an update which sets those, if they're present in libvirtd env.
> The changed bit is here:
> 
> +    ADD_ENV_COPY("LD_PRELOAD");
> +    ADD_ENV_COPY("LD_LIBRARY_PATH");
> +    ADD_ENV_COPY("PATH");
> +    ADD_ENV_COPY("HOME");
> +    ADD_ENV_COPY("USER");
> +    ADD_ENV_COPY("LOGNAME");
> +    ADD_ENV_COPY("TMPDIR");

  +1 again,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]