[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix index creation for disks > {sd,hd,xvd,vd}z



On Wed, Oct 08, 2008 at 06:23:05PM -0700, Chris Wright wrote:
> Calling virDiskNameToIndex with a disk name > {sd,hd,xvd,vd}z, such as
> vdaa, generates a bogus index.  Account for iterations through the loop.
> 
> Old behaviour:
> vda -> 0
> vdz -> 25
> vdaa -> 0
> vdaz -> 25
> 
> New behaviour:
> vda -> 0
> vdz -> 25
> vdaa -> 26
> vdaz -> 51
> 
> This was discovered by Sanjay Rao, thanks for the report.

ACK.

Good to know someone's testing scalability with > 26 disks :-)

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]