[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Unify most error reporting (ver 2)



On Thu, Oct 09, 2008 at 11:44:02AM -0400, Cole Robinson wrote:
> Daniel Veillard wrote:
> > On Wed, Oct 08, 2008 at 08:35:38PM +0100, Daniel P. Berrange wrote:
> >>> One side question: is src/xmlrpc.{c,h} even used? And
> >>> if not, can it be removed?
> >> It is not used at this time. It was for the hypothetical
> >> alternative Xen driver which talks XML-RPC which we never
> >> got around to writing. Perhaps it really is time to kill
> >> it -we can get it back from CVS if ever required.
> > 
> >   Agreed,
> > 
> >> ACK to this patch
> > 
> >   +1 too,
> > 
> > Daniel
> > 
> 
> Thanks, pushed now.

  Hum, this breaks "make check"

PASS: read-non-seekable
--- out 2008-10-10 10:23:57.000000000 +0200
+++ exp 2008-10-10 10:23:57.000000000 +0200
@@ -1,2 +1,2 @@
-libvir: Test error : internal error Domain is still running
+libvir: Test error test: internal error Domain is still running
 error: Failed to undefine domain test
 FAIL: undefine

Seems we loose the domain name in the error message when trying to
undefine a running domain:

paphio:~/libvirt/tests -> /usr/bin/virsh -q -c test:///default undefine
test
libvir: Test error test: internal error Domain is still running
error: Failed to undefine domain test
paphio:~/libvirt/tests -> ../src/virsh -q -c test:///default undefine
test
libvir: Test error : internal error Domain is still running
error: Failed to undefine domain test
paphio:~/libvirt/tests ->

I should be possible to restore the old behaviour of reporting the domain
name there

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]