[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: fix block stats for virtio and scsi



On Tue, Oct 07, 2008 at 03:03:10PM -0400, Cole Robinson wrote:
> Guido Günther wrote:
> > On Thu, Oct 02, 2008 at 09:06:25PM +0100, Daniel P. Berrange wrote:
> >> I think this needs to use the virDiskNameToIndex() method to
> >> extract the index instead.
> > Corrected pach attached. I don't know how devices are called when using
> > xenner so I left that out.
> >  -- Guido
> > 
> > 
> 
> There is actually a function in qemu_driver.c called
> qemudDiskDeviceName that handles a lot of this already,
> it's used for generating the connect/eject cdrom names.
> It's probably best to reuse that.
Yes this makes sense. After fixing things up a little in
virDiskNameToBusDeviceIndex and qemudDiskDeviceName this works. I'll
post this as 3 tiny patches since they might be helpful on their own and
can be applied in case there's still something wrong with the
blockstats.
 -- Guido


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]