[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] avoid many format string warnings



On Mon, Oct 13, 2008 at 02:21:07PM +0200, Jim Meyering wrote:
> Rather than manually editing 140+ diagnostics in 20 files (tedious
> and error-prone), I wrote a script to do the job (fun and reusable).
> There was only one change that required manual intervention,
> and that was because gcc doesn't yet know about the glibc/printf-
> specific %m format specifier.
> 
> One disadvantage of doing it this way is that lines can only get longer
> since I added no code to wrap them, but that is outweighed by being
> able to automate the process.  And who knows... maybe someone will be
> motivated to teach this little script how to break+reindent long lines.

  Sorry I can't read perl :-)
since this just shifts affected line by 4 columns the disruption is IMHO
fine,

  thanks a lot for the patch, +1 !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]