[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Couple of patches to fix remote connections from Windows



There's a mistake in the way drivers are registered which means that
if libvirt is configured with the remote driver but without libvirtd,
then the remote driver is compiled in but not registered, which means
it doesn't work.  The first patch fixes this.

The second patch just causes LIBVIRT_DEBUG to list drivers as they are
registered, which is useful for debugging these sorts of issues.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
Read my OCaml programming blog: http://camltastic.blogspot.com/
Fedora now supports 68 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
--- libvirt-0.4.6/src/libvirt.c.orig	2008-10-14 15:33:00.000000000 +0100
+++ libvirt-0.4.6/src/libvirt.c	2008-10-14 15:48:54.000000000 +0100
@@ -297,10 +297,10 @@
     if (lxcRegister() == -1) return -1;
 #endif
     if (storageRegister() == -1) return -1;
+#endif
 #ifdef WITH_REMOTE
     if (remoteRegister () == -1) return -1;
 #endif
-#endif
 
     return(0);
 }
--- libvirt-0.4.6/src/libvirt.c.orig	2008-09-22 14:12:12.000000000 +0100
+++ libvirt-0.4.6/src/libvirt.c	2008-10-14 15:30:56.000000000 +0100
@@ -540,6 +540,9 @@
         return -1;
     }
 
+    DEBUG ("registering %s as driver %d",
+           driver->name, virDriverTabCount);
+
     virDriverTab[virDriverTabCount] = driver;
     return virDriverTabCount++;
 }

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]