[libvirt] [PATCH] Add a Windows icon resource to virsh.exe

[Daniel P. Berrange]

On Wed, Oct 15, 2008 at 05:59:59PM +0100, Richard W.M. Jones wrote:
> On Wed, Oct 15, 2008 at 05:49:06PM +0100, Daniel P. Berrange wrote:
> > What color depth did you create the icons at ?
> 
> 32 bits (in GIMP).
> 
> > This blog posts suggest
> > the problem is more horrific than you can possibly imagine, requiring
> > a total of 12 icons to be provided for proper Windows compatability
> > 
> > http://frankieloscavio.blogspot.com/2007/10/ico-files-and-how-they-work-using-best.html
> > 
> > And apparently all the different versions should be in the same .ICO
> > file ?!?!
> 
> Uurrgghhhh.
> 
> I'm quite sure there used to be programs to generate and manipulate
> ICO files from Linux but I can't find any at the moment.  It doesn't
> necessarily matter if all the icons are combined into a single file or
> not, because i686-pc-mingw32-windres combines everything into a single
> resource object (a COFF object file) which gets linked to the final
> executable.
> 
> Suggest that we add the patch & icons as-is and let people who use
> Vista and/or are graphic designers deal with this in the future?

Yep, its an incremental improvement over nothing, so no objections
to commiting this as a starting point.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|