[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu/kvm: allow to hotadd scsi/virtio disks



On Fri, Oct 17, 2008 at 12:41:14PM +0200, Guido Günther wrote:
> On Fri, Oct 17, 2008 at 11:05:50AM +0100, Daniel P. Berrange wrote:
> > On Fri, Oct 17, 2008 at 09:48:58AM +0200, Guido G?nther wrote:
> > > Hi,
> > > recent kvm allows to hot add scsi/virtio disks, it uses pci hotplugging
> > > for that. Attached patch adds support for this to libvirt.
> > 
> > Great, I didn't know SCSI allowed hotplug in QEMU.
> Even NICs are hot pluggable now. And since qemu prints a reasonable OK
> message we can parse the PCI slot number from the reply which allows for
> unplugging as well (delayed that since I'm a bit short on time).
> 
> My patch contained a tiny error:
>  
> -+    safe_path = qemudEscapeShellArg(dev->data.disk->src);
> ++    safe_path = qemudEscapeMonitorArg(dev->data.disk->src);
> 
> corrected version attached,

  Looks fine, i just removed a couple of extra spaces at end of line
before commiting :-)

    thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]