[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH 1/4: More generic MAC address handling

On Tue, Oct 14, 2008 at 04:17:57PM +0100, Daniel P. Berrange wrote:
> This patch improves the MAC address handling.
> Currently our XML parser auto-generates a MAC addres using the KVM vendor
> prefix. This isn't much use for other drivers. This patch addresses this:
>  - Stores each driver's vendor prefix in the capability object
>  - Changes domain parser to use the per-driver vendor prefix for
>    generating mac addresses
>  - Adds more utility methods to util.c for parsing/generating/formatting
>    MAC addresses
>  - Updates each driver to record its vendor prefix for MAC address.
> NB, for LXC driver we're 'borrowing' KVM's vendor prefix. 

  Looks fine to me. Jim's raised an interesting point though,


Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]