[libvirt] errors building rpm

[Jim Meyering]

Cole Robinson <crobinso at redhat.com> wrote:
> Daniel P. Berrange wrote:
>> On Tue, Oct 21, 2008 at 04:39:36PM -0400, Ben Guthro wrote:
>>> I keep getting the following error when trying to build via a
>>> 'sudo make rpm' on the tip of the tree
>>>
>>> + /usr/lib/rpm/find-lang.sh /var/tmp/libvirt-0.4.6-1.fc9-root libvirt
>>> No translations found for libvirt in /var/tmp/libvirt-0.4.6-1.fc9-root
>>> error: Bad exit status from /var/tmp/rpm-tmp.82848 (%install)
>>>
>>>
>>> RPM build errors:
>>>     Bad exit status from /var/tmp/rpm-tmp.82848 (%install)
>>> make: *** [rpm] Error 1
>>>
>>>
>>> This looks like it came in with one of Jim Meyering's latest checkins.
>>
>> Looks like it probably failed to include any of the .po files. I see
>> Jim's change was essentially
>>
>> ALL_LINGUAS=`{cd "po" > /dev/null && ls *.po} | sed 's+\.po$++'`
>>
>> to
>>
>> ALL_LINGUAS=`{cd "$srcdir/po" > /dev/null && ls *.po} | sed 's+\.po$++'`
>>
>>
>> So my expectation is that '$srcdir' is not defined, and thus its trying
>> to use '/po' to find po files.

Hi Cole,

Actually I changed () to {}, too, and forgot to add the pesky ";"
before the closing "}".  I would have noticed sooner, but networking
on the box that normally builds libvirt is hosed, and I haven't
juggled things to go fix it yet.

So, one fix would be to add the semicolon, but
your change of removing the {} altogether is even better.

Thanks for fixing that!

ACK!

> I hit this last night. Attached patch fixed it for me, not
> sure if it breaks anything in subtle ways though. The actual
> error it's throwing is something like "'{cd' command not found"
>
> Thanks,
> Cole
>  configure.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.in b/configure.in
> index 66d271a..d2af4de 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -1011,7 +1011,7 @@ AM_CONDITIONAL([WITH_LIBVIRTD],[test "x$with_libvirtd" = "xyes"])
>  dnl Check for gettext
>  AM_GNU_GETTEXT_VERSION([0.14.1])
>  AM_GNU_GETTEXT([external])
> -ALL_LINGUAS=`{cd "$srcdir/po" > /dev/null && ls *.po} | sed 's+\.po$++'`
> +ALL_LINGUAS=`cd "$srcdir/po" > /dev/null && ls *.po | sed 's+\.po$++'`