[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 13/17] * qemud/remote_protocol.x: Include "remote_protocol.h" and <rpc/xdr.h>.



On Tue, Oct 28, 2008 at 12:21:30PM +0100, Jim Meyering wrote:
> From: Jim Meyering <meyering redhat com>
> 
> ---
>  qemud/remote_protocol.x |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/qemud/remote_protocol.x b/qemud/remote_protocol.x
> index b7e41aa..d15c549 100644
> --- a/qemud/remote_protocol.x
> +++ b/qemud/remote_protocol.x
> @@ -3,7 +3,7 @@
>   *   remote_internal driver and libvirtd.  This protocol is
>   *   internal and may change at any time.
>   *
> - * Copyright (C) 2006-2007 Red Hat, Inc.
> + * Copyright (C) 2006-2008 Red Hat, Inc.
>   *
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
> @@ -39,6 +39,9 @@
>  %#include <config.h>
>  %#include "internal.h"
>  %#include "socketcompat.h"
> +%#include "remote_protocol.h"

This file  is used to generate remote_protocol.h, so this results in
remote_protocol.h having a #include "remote_protocol.h", as well as
a double include in remote_protocol.c

> +%#include <rpc/xdr.h>

rpcgen automatically includes rpc/rpc.h, which should already include
the rpc/xdr.h file, so this seems redundant to me.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]